refactor: [M3-6302] - MUIv5 Migration - Components > CircleProgress #9028
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 flaky tests on run #3094 ↗︎
Details:
|
|||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| Managed navigation > allows access to Managed content when Managed is enabled |
Output
Screenshots
Video
|
|
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.
mjac0bs
reviewed
Apr 19, 2023
packages/manager/src/components/CircleProgress/CircleProgress.tsx
Outdated
Show resolved
Hide resolved
bnussman-akamai
approved these changes
Apr 19, 2023
Comment on lines
3
to
+4
|
|
||
| import CircleProgress from 'src/components/CircleProgress'; | ||
| import { CircleProgress } from 'src/components/CircleProgress'; |
There was a problem hiding this comment.
Unrelated to your work, but I've never been a fan of the spaces between imports
Suggested change
| import CircleProgress from 'src/components/CircleProgress'; | |
| import { CircleProgress } from 'src/components/CircleProgress'; | |
| import { CircleProgress } from 'src/components/CircleProgress'; |
There was a problem hiding this comment.
I'm not against it, we add spaces when destructuring objects too
jaalah-akamai
approved these changes
Apr 19, 2023
mjac0bs
approved these changes
Apr 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
How to test 🧪